Skip to content

Add riscv64-gnu to self-test #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

Add riscv64-gnu to self-test #1034

merged 1 commit into from
Nov 5, 2024

Conversation

Hoverbear
Copy link
Member

Missed this in #1027

@Hoverbear Hoverbear self-assigned this Oct 30, 2024
@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Oct 30, 2024
@bors-ferrocene
Try #1034:
286802f
@bors-ferrocene
Copy link
Contributor

try

Build failed:

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Oct 30, 2024
@bors-ferrocene
Try #1034:
d446d0e
@bors-ferrocene
Copy link
Contributor

try

Build failed:

@Hoverbear Hoverbear force-pushed the hoverbear/riscv64gc-self-test branch from 56f6aff to 523c21a Compare November 1, 2024 20:13
@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Nov 1, 2024
@bors-ferrocene
Try #1034:
9ac2e65
@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Nov 2, 2024

try

Build failed:

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Nov 4, 2024
@bors-ferrocene
Try #1034:
f7e2966
@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Nov 4, 2024

try

Build failed:

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Nov 4, 2024
@bors-ferrocene
Try #1034:
49791aa
@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Nov 4, 2024

try

Build succeeded:

tshepang
tshepang reviewed Nov 5, 2024
View reviewed changes
@Hoverbear Hoverbear requested a review from tshepang November 5, 2024 13:57
@tshepang
Copy link
Member

tshepang commented Nov 5, 2024

please squash, either 1 or 2 commits

@Hoverbear Hoverbear force-pushed the hoverbear/riscv64gc-self-test branch from 46245d3 to 3c9404f Compare November 5, 2024 15:23
@Hoverbear
Copy link
Member Author

@tshepang done :)

tshepang
tshepang approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@tshepang tshepang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@Hoverbear
Copy link
Member Author

(Noting this will almost certainly conflict with #1033 which is also due for merge, I'll resolve and seek re-approval.)

@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Nov 5, 2024

Merge conflict.

@Hoverbear Hoverbear force-pushed the hoverbear/riscv64gc-self-test branch from 3c9404f to 441d2a9 Compare November 5, 2024 19:33
@Hoverbear
Copy link
Member Author

bors merge

@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Nov 5, 2024

Build succeeded:

@bors-ferrocene bors-ferrocene bot merged commit 346d59e into main Nov 5, 2024
2 checks passed
@bors-ferrocene bors-ferrocene bot deleted the hoverbear/riscv64gc-self-test branch November 5, 2024 23:59
@github-actions github-actions bot added the backport:maybe PR candidate for backport label Nov 5, 2024
@pietroalbini pietroalbini added merged-in:1.83 and removed backport:maybe PR candidate for backport labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshepang tshepang tshepang approved these changes

+1 more reviewer

@amanjeev amanjeev amanjeev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Hoverbear Hoverbear

Labels
merged-in:1.83
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hoverbear @tshepang @amanjeev @pietroalbini