update for changes in pygfx@main #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kushalkolar do we need to update screenshots as well? |
To provide some context: we improved the points shader to consolidated the API, add support to express sizes in world/model space, and improve the shader code, making it more similar to the line shader. As part of that, the points are a tiny bit bigger, to counter for the edge we need to do anti-aliasing, so that aa and no-aa points look equally big. |
clewis7
added a commit
that referenced
this pull request
Mar 23, 2024
* update points material kwarg * update scatter examples & screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should update to most recent changes in pygfx