Skip to content

Add the ability to show generated VCL for a service version #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

Add the ability to show generated VCL for a service version #1498

merged 2 commits into from
Aug 7, 2025

Conversation

simonwistow
Copy link
Member

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change? - Adds a new command to show the generated VCL for a service-version

Are there any considerations that need to be addressed for release?

@simonwistow simonwistow requested a review from a team as a code owner June 17, 2025 02:31
@kpfleming
Copy link
Contributor

This looks great to me, but I'll leave the formal review/testing to Philipp :-) Thanks for the contribution!

philippschulte
philippschulte approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @simonwistow, apologies for the delay in reviewing this! I’ve gone through the changes and reached the same conclusion as @kpfleming. Thanks so much for this excellent work — really well done!

@kpfleming kpfleming enabled auto-merge (squash) August 7, 2025 14:28
@kpfleming kpfleming merged commit 5d02c32 into main Aug 7, 2025
12 checks passed
@kpfleming kpfleming deleted the simon/show-vcl branch August 7, 2025 14:38
@BrewTestBot BrewTestBot mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonwistow @kpfleming @philippschulte