breaking(language.rust): Switch Rust builds to wasm32-wasip1 instead of wasm32-wasi #1382

anthony-gomez-fastly · 2025-01-28T19:02:49Z

Breaking change to support Rust 1.84 and newer

BREAKING CHANGE:
Only the wasm32-wasip1 build target is accepted if a non default config is provided

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

Does your submission pass tests?

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully run tests with your changes locally?

Are there any considerations that need to be addressed for release?

this is a breaking change and will require a major version bump to prevent breakages

Integralist · 2025-01-30T12:52:48Z

LGTM, and I've approved the PR but we'll need either @kpfleming or @philippschulte to handle merging this PR and the subsequent new major release.

philippschulte

This looks great! I compared your changes to what Kevin recommended in the ticket. We're not cutting a new release before this has been tested and approved by Kevin. I would recommend to build binaries and share it internally for testing.

pkg/commands/compute/language_rust.go

.github/workflows/pr_test.yml

Dockerfile-rust

pkg/commands/compute/language_rust.go

kpfleming · 2025-02-07T14:29:34Z

I updated the PR title to reflect the purpose of the change, since it will end up in the changelog.

pkg/commands/compute/language_rust.go

addressed comments

…m32-wasi Breaking change to support Rust 1.84 and newer BREAKING CHANGE: Only the wasm32-waip1 build target is accepted if a non default config is provided

philippschulte

LGTM. Thank you!

…from wasm32-wasi (#1382)" This reverts commit 44ac1d6.

…from wasm32-wasi (#1382)" (#1399) This reverts commit 44ac1d6.

… from wasm32-wasi (#1382)" This reverts commit 3d20662.

… from wasm32-wasi (#1382)" (#1436) This reverts commit 3d20662.

anthony-gomez-fastly force-pushed the CDTOOL-1004-support-rust-1.84 branch 6 times, most recently from 5283bcd to 97ea81b Compare January 29, 2025 20:45

anthony-gomez-fastly marked this pull request as ready for review January 29, 2025 20:45

anthony-gomez-fastly requested review from kpfleming, Integralist and philippschulte January 29, 2025 20:46

Integralist previously approved these changes Jan 30, 2025

View reviewed changes

philippschulte added the breaking label Jan 30, 2025

philippschulte previously approved these changes Jan 30, 2025

View reviewed changes

pkg/commands/compute/language_rust.go Outdated Show resolved Hide resolved

anthony-gomez-fastly force-pushed the CDTOOL-1004-support-rust-1.84 branch from b9a2a4c to c7c0910 Compare January 30, 2025 19:01

anthony-gomez-fastly dismissed stale reviews from Integralist and philippschulte via 30cc440 January 30, 2025 21:37

anthony-gomez-fastly force-pushed the CDTOOL-1004-support-rust-1.84 branch from 30cc440 to c7c0910 Compare January 30, 2025 21:42

kpfleming requested changes Feb 6, 2025

View reviewed changes

anthony-gomez-fastly requested review from kpfleming and philippschulte February 6, 2025 22:24

anthony-gomez-fastly force-pushed the CDTOOL-1004-support-rust-1.84 branch 2 times, most recently from 3514cb3 to cca0fc1 Compare February 6, 2025 23:19

kpfleming changed the title ~~refactor(language.rust): check wasmwasi target and return error if mismatched~~ breaking(language.rust): Switch Rust builds to wasm32-wasip1 instead of wasm32-wasi Feb 7, 2025

kpfleming previously requested changes Feb 7, 2025

View reviewed changes

pkg/commands/compute/language_rust.go Outdated Show resolved Hide resolved

pkg/commands/compute/language_rust.go Outdated Show resolved Hide resolved

pkg/commands/compute/language_rust.go Outdated Show resolved Hide resolved

anthony-gomez-fastly force-pushed the CDTOOL-1004-support-rust-1.84 branch 4 times, most recently from 78969e3 to 98b8839 Compare February 10, 2025 15:18

anthony-gomez-fastly force-pushed the CDTOOL-1004-support-rust-1.84 branch from 98b8839 to bf30e4d Compare February 10, 2025 15:39

anthony-gomez-fastly commented Feb 10, 2025

View reviewed changes

pkg/commands/compute/language_rust.go Outdated Show resolved Hide resolved

anthony-gomez-fastly requested a review from kpfleming February 10, 2025 16:53

anthony-gomez-fastly force-pushed the CDTOOL-1004-support-rust-1.84 branch 2 times, most recently from 7e151fa to 21dbf42 Compare February 10, 2025 19:03

breaking(language.rust): switch Rust builds to wasm32-wasip1 from was…

5d02e7e

…m32-wasi Breaking change to support Rust 1.84 and newer BREAKING CHANGE: Only the wasm32-waip1 build target is accepted if a non default config is provided

anthony-gomez-fastly force-pushed the CDTOOL-1004-support-rust-1.84 branch from 21dbf42 to 5d02e7e Compare February 12, 2025 15:14

philippschulte approved these changes Feb 12, 2025

View reviewed changes

anthony-gomez-fastly merged commit 44ac1d6 into main Feb 12, 2025
9 checks passed

anthony-gomez-fastly deleted the CDTOOL-1004-support-rust-1.84 branch February 12, 2025 16:37

anthony-gomez-fastly added a commit that referenced this pull request Feb 13, 2025

Revert "breaking(language.rust): switch Rust builds to wasm32-wasip1 …

3d20662

…from wasm32-wasi (#1382)" This reverts commit 44ac1d6.

anthony-gomez-fastly added a commit that referenced this pull request Feb 13, 2025

Revert "breaking(language.rust): switch Rust builds to wasm32-wasip1 …

b4f7564

…from wasm32-wasi (#1382)" (#1399) This reverts commit 44ac1d6.

anthony-gomez-fastly added a commit that referenced this pull request Mar 10, 2025

Reapply "breaking(language.rust): switch Rust builds to wasm32-wasip1…

dbcca60

… from wasm32-wasi (#1382)" This reverts commit 3d20662.

anthony-gomez-fastly added a commit that referenced this pull request Mar 10, 2025

Reapply "breaking(language.rust): switch Rust builds to wasm32-wasip1…

0cf6cbb

… from wasm32-wasi (#1382)" This reverts commit 3d20662.

anthony-gomez-fastly added a commit that referenced this pull request Mar 12, 2025

Reapply "breaking(language.rust): switch Rust builds to wasm32-wasip1…

9a2a95b

… from wasm32-wasi (#1382)" (#1436) This reverts commit 3d20662.

BrewTestBot mentioned this pull request Mar 25, 2025

fastly 11.0.0 Homebrew/homebrew-core#216597

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

breaking(language.rust): Switch Rust builds to wasm32-wasip1 instead of wasm32-wasi #1382

breaking(language.rust): Switch Rust builds to wasm32-wasip1 instead of wasm32-wasi #1382

Uh oh!

anthony-gomez-fastly commented Jan 28, 2025 •

edited by kpfleming

Loading

Uh oh!

Integralist commented Jan 30, 2025

Uh oh!

philippschulte left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kpfleming commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philippschulte left a comment

Uh oh!

Uh oh!

Uh oh!

breaking(language.rust): Switch Rust builds to wasm32-wasip1 instead of wasm32-wasi #1382

breaking(language.rust): Switch Rust builds to wasm32-wasip1 instead of wasm32-wasi #1382

Uh oh!

Conversation

anthony-gomez-fastly commented Jan 28, 2025 • edited by kpfleming Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Feature Submissions:

Changes to Core Features:

Are there any considerations that need to be addressed for release?

Uh oh!

Integralist commented Jan 30, 2025

Uh oh!

philippschulte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kpfleming commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philippschulte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

anthony-gomez-fastly commented Jan 28, 2025 •

edited by kpfleming

Loading