Skip to content

fix(ci): fixed drivers_ci fedora container usage. #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix(ci): fixed drivers_ci fedora container usage. #2370

merged 1 commit into from
Apr 29, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Apr 24, 2025

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Same fix as falcosecurity/falco#3537

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
fix(ci): fixed drivers_ci fedora container usage.
769e9c7 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 24, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 24, 2025
@poiana poiana added the size/XS label Apr 24, 2025
@poiana poiana requested review from hbrueckner and mstemm April 24, 2025 07:26
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     4.18%     -0.63%  [.] next_event_from_file
     5.35%     +0.41%  [.] sinsp_parser::reset
    35.12%     +0.35%  [.] sinsp_thread_manager::create_thread_dependencies
     4.22%     +0.29%  [.] sinsp_thread_manager::find_thread
     1.93%     -0.21%  [.] sinsp_parser::process_event
     0.64%     +0.20%  [.] sinsp_evt::get_syscall_return_value
     1.35%     +0.18%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.57%     -0.17%  [.] sinsp_evt::get_param
     0.45%     +0.16%  [.] sinsp_fdtable::find
     0.98%     -0.14%  [.] sinsp_evt::get_ts

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0066         -0.0066           150           149           150           149
BM_sinsp_split_median                                          -0.0051         -0.0053           150           149           150           149
BM_sinsp_split_stddev                                          +0.2006         +0.2008             1             1             1             1
BM_sinsp_split_cv                                              +0.2085         +0.2089             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.1162         -0.1163            65            58            65            58
BM_sinsp_concatenate_paths_relative_path_median                -0.1100         -0.1101            65            58            65            58
BM_sinsp_concatenate_paths_relative_path_stddev                +0.3311         +0.3305             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    +0.5060         +0.5056             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0122         +0.0121            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0082         +0.0081            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +2.1479         +2.1650             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +2.1100         +2.1272             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0437         -0.0438            61            59            61            59
BM_sinsp_concatenate_paths_absolute_path_median                -0.0368         -0.0368            61            59            61            59
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.4109         -0.4108             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3840         -0.3838             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.02%. Comparing base (9f139a0) to head (769e9c7).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2370   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files         229      229           
  Lines       30336    30336           
  Branches     4657     4657           
=======================================
  Hits        23367    23367           
  Misses       6969     6969
Flag Coverage Δ
libsinsp 77.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops
Copy link
Contributor

ekoops commented Apr 24, 2025

/lgtm

@poiana poiana added the lgtm label Apr 24, 2025
@poiana
Copy link
Contributor

poiana commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 29, 2025
@poiana poiana merged commit e0db900 into master Apr 29, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 29, 2025
@poiana poiana deleted the fix/drivers_ci branch April 29, 2025 14:45
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnosek gnosek gnosek approved these changes

@leogr leogr leogr approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@gnosek gnosek

@leogr leogr

@ekoops ekoops

Labels
approved area/CI dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/XS
Projects
Falco Roadmap
Status: Done
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@FedeDP @ekoops @poiana @gnosek @leogr