Skip to content

Conversation

xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox added this to the v10.0 milestone Jul 5, 2025
@xDivisionByZerox xDivisionByZerox self-assigned this Jul 5, 2025
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner July 5, 2025 15:52
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: word Something is referring to the word module labels Jul 5, 2025
Copy link

netlify bot commented Jul 5, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4fe8abe
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/686a98ec948ebf0007f4501f
😎 Deploy Preview https://deploy-preview-3560.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xDivisionByZerox xDivisionByZerox requested a review from a team July 5, 2025 15:52
Copy link

codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (8972060) to head (4fe8abe).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3560      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2888     2888              
  Lines      221958   221958              
  Branches      930      929       -1     
==========================================
- Hits       221891   221889       -2     
- Misses         67       69       +2     
Files with missing lines Coverage Δ
src/modules/word/filter-word-list-by-length.ts 100.00% <100.00%> (ø)
src/modules/word/index.ts 96.40% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Shinigami92
Shinigami92 previously approved these changes Jul 5, 2025
Shinigami92
Shinigami92 previously approved these changes Jul 5, 2025
Shinigami92
Shinigami92 previously approved these changes Jul 6, 2025
@matthewmayer
Copy link
Contributor

@xDivisionByZerox looks like the example wasnt actually added in 81c8d29 ?

@xDivisionByZerox
Copy link
Member Author

Thanks for checking again. I musted have messed up the rebase when pulling the merged next branch. The example should be up now.

@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Jul 6, 2025
Merged via the queue into next with commit 93416f7 Jul 6, 2025
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the refactor/3263-switch-default-word-resolution-error-strategy branch July 6, 2025 15:46
@xDivisionByZerox xDivisionByZerox linked an issue Jul 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: word Something is referring to the word module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default word filtering strategy to fail
3 participants