Skip to content

Change default word filtering strategy to fail #3263

New issue
New issue
Closed
#3560
Closed
Change default word filtering strategy to fail#3263
#3560
Assignees
xDivisionByZerox
Labels
breaking changeCannot be merged when next version is not a major releasec: refactorPR that affects the runtime behavior, but doesn't add new features or fixes bugsm: wordSomething is referring to the word modulep: 1-normalNothing urgent
Milestone
v10.0
@ST-DDT

Description

@ST-DDT
ST-DDT
opened on Nov 14, 2024

faker/test/modules/word.spec.ts

Lines 66 to 73 in d31579b

it('returns the word list if no words match the length', () => {
const result = filterWordListByLength({
wordList,
length,
});
// TODO @ST-DDT 2022-10-02: This should throw an error in the next major version.
expect(result).toEqual(wordList);
});

IMO if the user specifies a specific length for their words, then by default it should fail if the request cannot be fulfilled.
If the user wants a different behavior, then they can still define an explicit error handling strategy.

Found while looking at: #3261

Metadata

Metadata

Assignees

Labels

breaking changeCannot be merged when next version is not a major releasec: refactorPR that affects the runtime behavior, but doesn't add new features or fixes bugsm: wordSomething is referring to the word modulep: 1-normalNothing urgent

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions