refactor(tests): move image filters tests from qunit to vitest #10547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
It seems that you opened a PR but you didn't add a line to the changelog file |
Smrtnyk
commented
Apr 17, 2025
src/shapes/Image-filters.spec.ts
Outdated
| }); | ||
|
|
||
| it('toJSON', () => { | ||
| // @ts-expect-error -- TODO: check this -- it is typed as boolean but we are passing number here |
There was a problem hiding this comment.
@asturur left a comment here in case you want to check it out
I assume boolean should be passed here instead of the number
or the type is wrong
there is also this same todo on 2 more places
There was a problem hiding this comment.
Yes the test was wrong, it makes sense as a boolean and the code behave as boolean.
|
Build Stats
|
|
asturur
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this moves image filters tests from qunit to vitest