Skip to content

refactor(tests): move image tests from qunit to vitest #10546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2025
Merged

refactor(tests): move image tests from qunit to vitest #10546

merged 5 commits into from
Apr 19, 2025

Conversation

Smrtnyk
Copy link
Contributor

@Smrtnyk Smrtnyk commented Apr 17, 2025

oh boy this one was intense
moves image tests from qunit to vitest

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Apr 17, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

It seems that you opened a PR but you didn't add a line to the changelog file
Please under the ## [next] version tag, add a line describing the changes of your pr with this format:
ci/chore/tests/feature/fix(): Some extended description #10546
Example:

  refactor(tests): move image tests from qunit to vitest [#10546](https://github.com/fabricjs/fabric.js/pull/10546)

Smrtnyk
Smrtnyk commented Apr 17, 2025
View reviewed changes
vitest.config.ts
@@ -17,6 +17,7 @@ export default defineConfig({
test: {
pool: 'vmThreads',
clearMocks: true,
mockReset: true,
Copy link
Contributor Author

@Smrtnyk Smrtnyk Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that spies were leaking between tests which made it very hard to test something in image suite
this made some other tests to break in Itext which I adapted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this should be the default honestly.

Smrtnyk
Smrtnyk commented Apr 17, 2025
View reviewed changes
src/shapes/Image.spec.ts
return img;
}

export async function createImage(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworked these helpers a bit
because the version from qunit was a bit crazy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider some tests are super super old and written with different expertise compared to today standards and capabilities.

@github-actions GitHub Actions
Copy link
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 913.863 (0) 301.232 (0)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2025 •
edited
Loading 


> fabric@6.6.2 coverage:report:ci
> nyc report --reporter=text-summary


=============================== Coverage summary ===============================
Statements   : 74.94% ( 21539/28739 )
Branches     : 60.51% ( 4003/6615 )
Functions    : 87.52% ( 1579/1804 )
Lines        : 79.22% ( 16412/20715 )
================================================================================

@asturur asturur merged commit 4378b63 into fabricjs:master Apr 19, 2025
20 checks passed
@Smrtnyk Smrtnyk deleted the refactor(tests)-move-image-tests-from-qunit-to-vitest branch April 20, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smrtnyk @asturur