Skip to content

refactor(tests): move object geometry tests from qunit to vitest #10539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2025
Merged

refactor(tests): move object geometry tests from qunit to vitest #10539

merged 3 commits into from
Apr 16, 2025

Conversation

Smrtnyk
Copy link
Contributor

@Smrtnyk Smrtnyk commented Apr 15, 2025

this moves object geometry tests from qunit to vitest

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Apr 15, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

It seems that you opened a PR but you didn't add a line to the changelog file
Please under the ## [next] version tag, add a line describing the changes of your pr with this format:
ci/chore/tests/feature/fix(): Some extended description #10539
Example:

  refactor(tests): move object geometry tests from qunit to vitest [#10539](https://github.com/fabricjs/fabric.js/pull/10539)

@asturur
Copy link
Member

asturur commented Apr 16, 2025

I should be able to have the action that updates the changelog to work from forked prs now. I ll do that asap so that the PR title is reflected in the changelog automatically

@github-actions GitHub Actions
Copy link
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 913.863 (0) 301.232 (0)

@Smrtnyk
Copy link
Contributor Author

Smrtnyk commented Apr 16, 2025

I should be able to have the action that updates the changelog to work from forked prs now. I ll do that asap so that the PR title is reflected in the changelog automatically

yeah that would make things more enjoyable

@github-actions GitHub Actions
Copy link
Contributor 


> fabric@6.6.2 coverage:report:ci
> nyc report --reporter=text-summary


=============================== Coverage summary ===============================
Statements   : 72.94% ( 20958/28732 )
Branches     : 60.12% ( 3881/6455 )
Functions    : 87.33% ( 1572/1800 )
Lines        : 77.54% ( 16061/20712 )
================================================================================

@asturur asturur merged commit fe2aabe into fabricjs:master Apr 16, 2025
21 checks passed
@Smrtnyk Smrtnyk deleted the refactor(tests)-move-object-geometry-from-qunit-to-vitest branch April 17, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smrtnyk @asturur