Adding missing includes which are necessary for building. #3533
Conversation
|
Hi @mfixman! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| @@ -12,6 +12,8 @@ | |||
| #include <cstring> | |||
| #include <map> | |||
| #include <random> | |||
| #include <set> | |||
| #include <algorithm> | |||
There was a problem hiding this comment.
How about removing algorithm? I don't see where we use it
There was a problem hiding this comment.
It's used in a std::find call in this file.
There was a problem hiding this comment.
Hi @mfixman, I think you are right. I'm wondering if you could put #include in between #include <omp.h> and #include . The format doesn't pass. Once you fix it, I could merge it
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: The current version of Faiss cannot be built due to missing `#include`s on a test file `tests/test_ivf_index.cpp`. This is better described in issue [https://github.com/facebookresearch/faiss/issues/3532](https://github.com/facebookresearch/faiss/issues/3532). This adds the missing imports. Reviewed By: asadoughi Differential Revision: D58899187 Pulled By: junjieqi
Summary: Pull Request resolved: #3609 The current version of Faiss cannot be built due to missing #includes on a test file tests/test_ivf_index.cpp. This is better described in issue #3532. #3533 Reviewed By: ramilbakhshyiev Differential Revision: D59314273 fbshipit-source-id: 6ec8bfa973760d0a44bc94ae751b4fc55c4784ef
|
fixed |
…earch#3609) Summary: Pull Request resolved: facebookresearch#3609 The current version of Faiss cannot be built due to missing #includes on a test file tests/test_ivf_index.cpp. This is better described in issue facebookresearch#3532. facebookresearch#3533 Reviewed By: ramilbakhshyiev Differential Revision: D59314273 fbshipit-source-id: 6ec8bfa973760d0a44bc94ae751b4fc55c4784ef
…earch#3609) Summary: Pull Request resolved: facebookresearch#3609 The current version of Faiss cannot be built due to missing #includes on a test file tests/test_ivf_index.cpp. This is better described in issue facebookresearch#3532. facebookresearch#3533 Reviewed By: ramilbakhshyiev Differential Revision: D59314273 fbshipit-source-id: 6ec8bfa973760d0a44bc94ae751b4fc55c4784ef
The current version of Faiss cannot be built due to missing
#includes on a test filetests/test_ivf_index.cpp. This is better described in issue #3532.This adds the missing imports.