Improve distances_simd.cpp for aarch64 #2392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😞 |
37e8840 to
c2eeef2
Compare
c2eeef2 to
48c2848
Compare
|
@mdouze has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
BZO95
added a commit
to BZO95/faiss
that referenced
this pull request
Apr 10, 2025
Summary:
- use `vaddvq_f32` instead of `vpaddq_f32` and `vdups_laneq_f32` in `fvec_L2sqr` , `fvec_inner_product` , and `fvec_norm_L2sqr`
- ~~implement `fvec_L1` and `fvec_Linf` for ARM SIMD (NEON)~~
- This causes performance regression, so I've droped it.
- implement `fvec_madd` and `fvec_madd_and_argmin` for ARM SIMD (NEON)
Pull Request resolved: facebookresearch/faiss#2392
Reviewed By: patricklabatut
Differential Revision: D38198174
Pulled By: mdouze
fbshipit-source-id: 3488a0cf2db1ded458b3bf73f4bc9665413e3351
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Apr 10, 2025
Summary:
- use `vaddvq_f32` instead of `vpaddq_f32` and `vdups_laneq_f32` in `fvec_L2sqr` , `fvec_inner_product` , and `fvec_norm_L2sqr`
- ~~implement `fvec_L1` and `fvec_Linf` for ARM SIMD (NEON)~~
- This causes performance regression, so I've droped it.
- implement `fvec_madd` and `fvec_madd_and_argmin` for ARM SIMD (NEON)
Pull Request resolved: facebookresearch#2392
Reviewed By: patricklabatut
Differential Revision: D38198174
Pulled By: mdouze
fbshipit-source-id: 3488a0cf2db1ded458b3bf73f4bc9665413e3351
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Apr 10, 2025
Summary:
- use `vaddvq_f32` instead of `vpaddq_f32` and `vdups_laneq_f32` in `fvec_L2sqr` , `fvec_inner_product` , and `fvec_norm_L2sqr`
- ~~implement `fvec_L1` and `fvec_Linf` for ARM SIMD (NEON)~~
- This causes performance regression, so I've droped it.
- implement `fvec_madd` and `fvec_madd_and_argmin` for ARM SIMD (NEON)
Pull Request resolved: facebookresearch#2392
Reviewed By: patricklabatut
Differential Revision: D38198174
Pulled By: mdouze
fbshipit-source-id: 3488a0cf2db1ded458b3bf73f4bc9665413e3351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vaddvq_f32instead ofvpaddq_f32andvdups_laneq_f32infvec_L2sqr,fvec_inner_product, andfvec_norm_L2sqrimplementfvec_L1andfvec_Linffor ARM SIMD (NEON)fvec_maddandfvec_madd_and_argminfor ARM SIMD (NEON)