Handle plain SearchParameters in HNSW searches (#4167) #4174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Author: Kaival Parikh kaivalp2000@gmail.com
(This required some updates to an internal unit test to pass the internal Meta CI, so I had to unlink and re-export as this new PR)
Summary from #4167 below:
Summary:
Add ability to search HNSW indexes using a plain
SearchParameters
object (i.e. only anIDSelector
)Issue: Currently if a plain
SearchParameters
is used to query an HNSW index, an error is thrown -- when the user's intent was only to filter some documents, and rely on index settings for remaining parameters (likeefSearch
,check_relative_distance
,search_bounded_queue
)Motivation: Faiss provides an amazing index factory and parameter setter to abstract away internals of the index type and settings used, like:
Now if a user wants to perform a filtered search on this opaque index using:
they are met with an error:
An easy way to reproduce this issue is to replace
Flat
->HNSW
here and runexample_c
like:This PR allows passing a plain
SearchParameters
to HNSW indexes, and use index settings as a fallbackReviewed By: asadoughi
Differential Revision: D69266072
Pulled By: mnorris11