Prepare for next React Native sync with new instance format #36438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D43980374 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D43980374 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Mar 10, 2023
…#36438) Summary: Pull Request resolved: facebook#36438 This makes the `react-native` repository compatible with the next sync from react after the changes in facebook/react#26321 land. That PR is changing the format of the Fabric instance and we have a few instances where we assume the internal structure of that instance in the repository. Changelog: [internal] Differential Revision: D43980374 fbshipit-source-id: d2e5c03dc595bd181fbdfb1bed28155dd3840e40
b1c58c6 to
02ea417
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43980374 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Mar 10, 2023
…#36438) Summary: Pull Request resolved: facebook#36438 This makes the `react-native` repository compatible with the next sync from react after the changes in facebook/react#26321 land. That PR is changing the format of the Fabric instance and we have a few instances where we assume the internal structure of that instance in the repository. Changelog: [internal] Differential Revision: D43980374 fbshipit-source-id: 5df8ef99fb884b60e4c112eeb5dbe97cdefa9dd1
02ea417 to
88922c5
Compare
Base commit: cfa03db |
Summary: This migrates FabricUIManager to Flow strict. Changelog: [internal] Differential Revision: D43773032 fbshipit-source-id: 60ee1c35843ba2b51ec44f9be65053182f269dc6
…#36438) Summary: Pull Request resolved: facebook#36438 This makes the `react-native` repository compatible with the next sync from react after the changes in facebook/react#26321 land. That PR is changing the format of the Fabric instance and we have a few instances where we assume the internal structure of that instance in the repository. Changelog: [internal] Reviewed By: yungsters Differential Revision: D43980374 fbshipit-source-id: 8b716f2e4a99ac0312bfe6927f364429e94c9574
|
This pull request was exported from Phabricator. Differential Revision: D43980374 |
88922c5 to
c51fe74
Compare
|
This pull request was successfully merged by @rubennorte in 803bb16. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in 803bb16. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…#36438) Summary: Pull Request resolved: facebook#36438 This makes the `react-native` repository compatible with the next sync from react after the changes in facebook/react#26321 land. That PR is changing the format of the Fabric instance and we have a few instances where we assume the internal structure of that instance in the repository. Changelog: [internal] Reviewed By: yungsters Differential Revision: D43980374 fbshipit-source-id: 718b504ff7c5bb6088c553e0256489b04d92b653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This makes the
react-nativerepository compatible with the next sync from react after the changes in facebook/react#26321 land.That PR is changing the format of the Fabric instance and we have a few instances where we assume the internal structure of that instance in the repository.
Changelog: [internal]
Differential Revision: D43980374