SYSTEM_ALERT_WINDOW only in debug builds #23504
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjiawen
approved these changes
Feb 18, 2019
facebook-github-bot
approved these changes
Feb 18, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulmandakh merged commit 84a2fb0 into |
|
@dulmandakh Can you import the related change to RNTester ? |
ericlewis
pushed a commit
to ericlewis/react-native
that referenced
this pull request
Feb 20, 2019
Summary: SYSTEM_ALERT_WINDOW permission is used only for debug builds to show draw overlay views or show warnings/errors. This permissions is unused in release builds, and there is an issue regarding removing unused permissions on Android build facebook#5886 (comment). This PR removes SYSTEM_ALERT_WINDOW from all builds bug debug. [Android] [Changed] - SYSTEM_ALERT_WINDOW permissions available only in debug builds Pull Request resolved: facebook#23504 Differential Revision: D14123045 Pulled By: cpojer fbshipit-source-id: 68829a774ff23c7cb2721076a9d3870405f48fea
grabbou
pushed a commit
that referenced
this pull request
Feb 27, 2019
Summary: SYSTEM_ALERT_WINDOW permission is used only for debug builds to show draw overlay views or show warnings/errors. This permissions is unused in release builds, and there is an issue regarding removing unused permissions on Android build #5886 (comment). This PR removes SYSTEM_ALERT_WINDOW from all builds bug debug. [Android] [Changed] - SYSTEM_ALERT_WINDOW permissions available only in debug builds Pull Request resolved: #23504 Differential Revision: D14123045 Pulled By: cpojer fbshipit-source-id: 68829a774ff23c7cb2721076a9d3870405f48fea
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SYSTEM_ALERT_WINDOW permission is used only for debug builds to show draw overlay views or show warnings/errors. This permissions is unused in release builds, and there is an issue regarding removing unused permissions on Android build #5886 (comment). This PR removes SYSTEM_ALERT_WINDOW from all builds bug debug.
Changelog
[Android] [Changed] - SYSTEM_ALERT_WINDOW permissions available only in debug builds
Test Plan
CI is green, and I tested it in my apps.