Remove ignored iOS schemes from template #26471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cc @cpojer I think that I saw that in 0.61 we are cleaning up the xcodeproj files so prob it would be good to have this merged too |
facebook-github-bot
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @friederbluemle in 3e4c5c0. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 29, 2020
Summary: Adding `xcscheme` files for iOS template back in. They were removed in #26471 after #25451. We have reverted the change on `.gitignore`, as this directory is supposed to be in git, but we didn't revert the removed files. Now they are back as well. You can also see here that the two files are still missing, they got removed on rc.0 and are still missing on rc.3. https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.0-rc.3 ## Changelog [iOS] [Changed] - Add `xcscheme` files for iOS template back in. Pull Request resolved: #28198 Test Plan: `init` a nre project, and check if the files are there or not. The paths are `ios/MyApp.xcodeproj/xcshareddata/xcschemes/MyApp.xcscheme` and `ios/MyApp.xcodeproj/xcshareddata/xcschemes/MyApp-tvOS.xcscheme` Reviewed By: cpojer Differential Revision: D20179447 Pulled By: TheSavior fbshipit-source-id: b0f08c0f32d6bb7630179bc2fe46d9ac10f6c1d7
alloy
pushed a commit
that referenced
this pull request
Mar 5, 2020
Summary: Adding `xcscheme` files for iOS template back in. They were removed in #26471 after #25451. We have reverted the change on `.gitignore`, as this directory is supposed to be in git, but we didn't revert the removed files. Now they are back as well. You can also see here that the two files are still missing, they got removed on rc.0 and are still missing on rc.3. https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.0-rc.3 ## Changelog [iOS] [Changed] - Add `xcscheme` files for iOS template back in. Pull Request resolved: #28198 Test Plan: `init` a nre project, and check if the files are there or not. The paths are `ios/MyApp.xcodeproj/xcshareddata/xcschemes/MyApp.xcscheme` and `ios/MyApp.xcodeproj/xcshareddata/xcschemes/MyApp-tvOS.xcscheme` Reviewed By: cpojer Differential Revision: D20179447 Pulled By: TheSavior fbshipit-source-id: b0f08c0f32d6bb7630179bc2fe46d9ac10f6c1d7
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Adding `xcscheme` files for iOS template back in. They were removed in facebook#26471 after facebook#25451. We have reverted the change on `.gitignore`, as this directory is supposed to be in git, but we didn't revert the removed files. Now they are back as well. You can also see here that the two files are still missing, they got removed on rc.0 and are still missing on rc.3. https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.0-rc.3 ## Changelog [iOS] [Changed] - Add `xcscheme` files for iOS template back in. Pull Request resolved: facebook#28198 Test Plan: `init` a nre project, and check if the files are there or not. The paths are `ios/MyApp.xcodeproj/xcshareddata/xcschemes/MyApp.xcscheme` and `ios/MyApp.xcodeproj/xcshareddata/xcschemes/MyApp-tvOS.xcscheme` Reviewed By: cpojer Differential Revision: D20179447 Pulled By: TheSavior fbshipit-source-id: b0f08c0f32d6bb7630179bc2fe46d9ac10f6c1d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The merge of #25451 added
xcshareddatato the .gitignore file intemplate. Two xcscheme files in thexcschemessubfolder were still left in the template and should have been removed at the same time.The project opens and builds fine without the xcscheme files both from command line and in Xcode.
Changelog
[iOS] [Changed] - Remove ignored iOS schemes from template
Test Plan
Generate new project, remove files, verify that project builds, and opens correctly in Xcode.
Please review @karanjthakkar @satya164 @kelset