Integration test stability: add delay before starting TimersTest #10548
Conversation
|
By analyzing the blame information on this pull request, we identified @sebmarkbage to be a potential reviewer. |
|
@bestander here's another change that I think might improve test stability.... |
|
@facebook-github-bot shipit |
|
@bestander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thanks, @dlowder-salesforce. I looked at the last 10 build failures on Master branch https://travis-ci.org/facebook/react-native/builds/170729100 |
|
@bestander Looks like there are intermittent failures with testLogging and testPropertiesUpdateTest. The latter happens when the simulator won't come up sometimes, and can also happen in objc-test-ios. The logging test failures seem to be cases where the message text doesn't match expected values when running the tvOS tests. It's a bit strange -- I would expect those failures to happen every time, or not at all. I'll take a look. |
|
Interesting.... If I restart the packager and remove UIExplorer app from the tvOS simulator, it seems to fail every time, but not always at the same line. Bizarre. It succeeds after that. |
|
@bestander Found the issue. On tvOS, logging messages (due to missing components that don't exist in tvOS) are arriving at the same time as the test log messages, causing intermittent test failures. Submitting a PR to fix this. |
Summary: * Motivation Locally I'm seeing consistent failures in IntegrationTests/TimersTest.js. Adding a little delay before starting the first test seems to make these issues go away. Closes facebook#10548 Differential Revision: D4080920 Pulled By: bestander fbshipit-source-id: 2dec86073786658f24b809284123815e77fbbd99
Locally I'm seeing consistent failures in IntegrationTests/TimersTest.js. Adding a little delay before starting the first test seems to make these issues go away.