Apple TV support 4: support for input (tvOS focus engine) #10427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @caabernathy and @jacobp100 to be potential reviewers. |
|
I don’t think I’m the right person to be reviewing this! Maybe you could ping the people who did the previous reviews! |
|
@dlowder-salesforce updated the pull request - view changes |
|
@javache @bestander here is the next round of Apple TV changes. |
|
@dlowder-salesforce updated the pull request - view changes |
|
@dlowder-salesforce updated the pull request - view changes |
|
Weird, now the TabBar snapshot test is failing for tvOS.... not seeing that locally |
|
Is that what Travis was failing on? It looked like a properties update test to me. I'll restart Travis fwiw. |
|
@javache import failed again... please let me know if there is anything I can do to help resolve the issue. |
…ce/react-native into tvOSfocusengine
|
Landed in c92ad5f! |
douglowder
added a commit
to douglowder/react-native
that referenced
this pull request
Dec 19, 2016
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 21, 2016
Summary: **Motivation** After reviewing changes between my PR #10427 and what was eventually manually imported to master, found two minor adjustments needed. **Test plan** Existing tests should still pass. Closes #11548 Differential Revision: D4357216 Pulled By: javache fbshipit-source-id: 571794cda104210bf5236462c0700e07a2a51d29
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Dec 30, 2016
Summary: **Motivation** After reviewing changes between my PR facebook#10427 and what was eventually manually imported to master, found two minor adjustments needed. **Test plan** Existing tests should still pass. Closes facebook#11548 Differential Revision: D4357216 Pulled By: javache fbshipit-source-id: 571794cda104210bf5236462c0700e07a2a51d29
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: **Motivation** After reviewing changes between my PR facebook#10427 and what was eventually manually imported to master, found two minor adjustments needed. **Test plan** Existing tests should still pass. Closes facebook#11548 Differential Revision: D4357216 Pulled By: javache fbshipit-source-id: 571794cda104210bf5236462c0700e07a2a51d29
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 15, 2017
Summary: The `focusedOpacity` prop is only used inside `_opacityFocused` which is not used anywhere. This pr removes this unused code. The code was added in #10427 but it does not appear to be used in the final version of the pr. Closes #14984 Differential Revision: D5430611 Pulled By: shergin fbshipit-source-id: 0bc4fdef04304eae9785caaf76ae1fb12ce6651e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Apple TV React Native apps actually work by supporting Siri Remote and keyboard input through the TouchableHighlight and TouchableOpacity components. Also enable input into TextInput components, and support TabBarIOS. Add an API for changing which component has the tvOS focus.
Existing Apple TV automation still passes. Reenabling existing snapshot tests for Apple TV. Will add snapshot tests later for verifying the tvOS focus API.