Add proptypes for scrollview drag start & end handlers #17368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
|
Hmm. I see a test failure, but it looks unrelated to my change. Anyone able to help? |
|
Looks good to me. It appears that these undocumented props were called by the ScrollResponder mixin: |
facebook-github-bot
approved these changes
Dec 28, 2017
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mathiasbynens
pushed a commit
to mathiasbynens/react-native
that referenced
this pull request
Jan 13, 2018
Summary: `ScrollView` has a bunch of `onFoo` handlers for scrolling-related events, most of which have a proptype defined and are documented. However, `onScrollBeginDrag` and `onScrollEndDrag` do not currently have a proptype and are not currently documented (as noted at https://stackoverflow.com/a/41793747/1709587). It seems reasonable to bring consistency and to provide documentation of these otherwise hard-to-discover props. I haven't added or run any tests, and don't plan to do so (beyond waiting and seeing that no existing checks fail in CircleCI). I have also created a PR to update the documentation at facebook/react-native-website#99 *(None needed; this isn't a functionality change.)* Closes facebook#17368 Differential Revision: D6642695 Pulled By: TheSavior fbshipit-source-id: fa40ed2ae6d5947a161b816a47441d8f5d4d9c4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ScrollViewhas a bunch ofonFoohandlers for scrolling-related events, most of which have a proptype defined and are documented. However,onScrollBeginDragandonScrollEndDragdo not currently have a proptype and are not currently documented (as noted at https://stackoverflow.com/a/41793747/1709587). It seems reasonable to bring consistency and to provide documentation of these otherwise hard-to-discover props.Test Plan
I haven't added or run any tests, and don't plan to do so (beyond waiting and seeing that no existing checks fail in CircleCI).
Related PRs
I have also created a PR to update the documentation at facebook/react-native-website#99
Release Notes(None needed; this isn't a functionality change.)