Update buck to v2017.11.16.01 #16861
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Buck install step succeeded, landing. |
facebook-github-bot
approved these changes
Nov 17, 2017
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This is actually causing another failure few steps later -> https://circleci.com/gh/facebook/react-native/26294?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link. It fails with:
I wasn't able to fix it and decided to revert it back to old version on 0.51. It's unfortunate that so many issues are happening. |
cdlewis
pushed a commit
to cdlewis/react-native
that referenced
this pull request
Nov 19, 2017
Summary: Android tests on CI have been failing since late October due to dd016f3 which makes use of a new Buck feature, `required_for_source_only_abi`. Circle was using an older September release. In this PR, we update to the latest release. Green is good. Red is bad. Wait for Circle to run. [INTERNAL][BUGFIX][./circleci/config.yml] - Update Buck version Closes facebook#16861 Differential Revision: D6355335 Pulled By: hramos fbshipit-source-id: 411d0b229f0dfb7e9dfc07c300b6546bf7afcdfe
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: Android tests on CI have been failing since late October due to dd016f3 which makes use of a new Buck feature, `required_for_source_only_abi`. Circle was using an older September release. In this PR, we update to the latest release. Green is good. Red is bad. Wait for Circle to run. [INTERNAL][BUGFIX][./circleci/config.yml] - Update Buck version Closes facebook#16861 Differential Revision: D6355335 Pulled By: hramos fbshipit-source-id: 411d0b229f0dfb7e9dfc07c300b6546bf7afcdfe
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: Android tests on CI have been failing since late October due to dd016f3 which makes use of a new Buck feature, `required_for_source_only_abi`. Circle was using an older September release. In this PR, we update to the latest release. Green is good. Red is bad. Wait for Circle to run. [INTERNAL][BUGFIX][./circleci/config.yml] - Update Buck version Closes facebook#16861 Differential Revision: D6355335 Pulled By: hramos fbshipit-source-id: 411d0b229f0dfb7e9dfc07c300b6546bf7afcdfe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android tests on CI have been failing since late October due to dd016f3 which makes use of a new Buck feature,
required_for_source_only_abi. Circle was using an older September release. In this PR, we update to the latest release.Motivation
Green is good. Red is bad.
Test Plan
Wait for Circle to run.
Release Notes
[INTERNAL][BUGFIX][./circleci/config.yml] - Update Buck version