chore: remove accessibilityComponentType and accessibilityTraits props #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-native ready! Built with commit 7283827 https://deploy-preview-873--react-native.netlify.com Changes to Thank you for your contributions. |
charpeni
reviewed
Apr 18, 2019
| - [`accessibilityComponentType`](view.md#accessibilitycomponenttype) | ||
| - [`testID`](view.md#testid) <<<<<<< Updated upstream | ||
| - # [`accessibilityComponentType`](view.md#accessibilitycomponenttype) | ||
| > > > > > > > Stashed changes |
There was a problem hiding this comment.
This doesn't look right, @elucaswork can you look at this?
charpeni
reviewed
Apr 18, 2019
| - [`accessibilityTraits`](view.md#accessibilitytraits) | ||
| - [`accessibilityStates`](view.md#accessibilitystates) <<<<<<< Updated upstream | ||
| - # [`accessibilityTraits`](view.md#accessibilitytraits) | ||
| > > > > > > > Stashed changes |
There was a problem hiding this comment.
This doesn't look right, @elucaswork can you look at this?
|
Oops, sorry @charpeni I totally missed those. Could you resolve these? |
cpojer
pushed a commit
that referenced
this pull request
Apr 18, 2019
JackWillie
added a commit
to JackWillie/react-native-website
that referenced
this pull request
Nov 27, 2022
facebook/react-native-website#873 got merged with conflicts. Fixing it now. My bad. cc @charpeni @cpojer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facebook/react-native#24344
Remove deprecated
accessibilityComponentTypeandaccessibilityTraitsprops.