Skip to content

fix: Allow MCP server to fix issues when asked to #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 28, 2025

Prerequisites checklist

What is the purpose of this pull request?

Make it so the MCP server will allow agents to automatically fix lint errors when the user has provided those instructions.

What changes did you make? (Give an overview)

  • Changed the prompt in the lint-files tool to state that the lint issues can be fixed if the user has instruction the agent to do so.
  • Also updated the lint-files result so that it will always output the lint results regardless if fixes were applied. (By default, it seemed like the agent would not output the full results because it would prioritize fixing the found issues over displaying issues it was fixing.)

Related Issues

fixes #246

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 28, 2025
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jul 28, 2025
@nzakas
Copy link
Member Author

nzakas commented Jul 28, 2025

@hughescr Can you try out this change and see if it works for you?

I think this should work: `npx 'https://gitpkg.vercel.app/eslint/rewrite/packages/mcp?issue246'

@fasttime fasttime moved this from Needs Triage to Implementing in Triage Jul 29, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit e54bc88 into main Jul 29, 2025
21 checks passed
@fasttime fasttime deleted the issue246 branch July 29, 2025 18:32
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jul 29, 2025
@github-actions github-actions bot mentioned this pull request Jul 29, 2025
@hughescr
Copy link

Thanks - the concept looks good; let me try it out and lyk

@hughescr
Copy link

I had to switch to https://gitpkg.vercel.app/eslint/rewrite/packages/mcp?main (?issue246 didn't work), but it's going well so far after a day of use.

@hughescr
Copy link

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Change Request: [MCP] Optionally remove the "Do not automatically fix these issues" trailer
4 participants