Skip to content

test: rename test file and correct type in MCP #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

lumirlumir
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Hello,

In this PR, I renamed mcp-cli.js to mcp-cli.test.js for consistency with test file naming, and corrected the type from ChildProcess to childProcess.ChildProcess.

No major changes were made, just a few small fixes.

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 61dcb19 into main Jul 21, 2025
21 checks passed
@nzakas nzakas deleted the test-rename-test-file-and-correct-type-in-mcp branch July 21, 2025 15:28
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants