Skip to content

fix: explicit matching behavior with negated patterns and arrays #19845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #19813
Fixes #19814

What changes did you make? (Give an overview)

Updated @eslint/config-array to v0.20.1, which includes fixes for #19813 (eslint/rewrite#220) and #19814 (eslint/rewrite#218), and added tests to confirm that #19813 and #19814 are fixed. All added tests are failing with @eslint/config-array v0.20.0.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner June 12, 2025 11:12
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 12, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jun 12, 2025
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 5e09896
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/684ab6032634ee0008487bd1

@mdjermanovic mdjermanovic added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 12, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like @fasttime to review before merging.

@nzakas nzakas moved this from Needs Triage to Second Review Needed in Triage Jun 12, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 85c082c into main Jun 13, 2025
35 of 43 checks passed
@fasttime fasttime deleted the issue19813-19814 branch June 13, 2025 04:11
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: Patterns in arrays are not considered explicit match Bug: Negated patterns are considered explicit match
3 participants