fix: explicit match in array elements of files
#218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
reviewed
Jun 5, 2025
| const nonUniversalFiles = []; | ||
| const universalFiles = config.files.filter(element => { | ||
| if (Array.isArray(element)) { | ||
| if ( |
There was a problem hiding this comment.
Maybe we can add a comment here to explain that because an array is an AND operation, then all items in the array need to be universal for it to be considered universal? (Assuming I'm reading this correctly.)
There was a problem hiding this comment.
Added a comment in e5d3270
1 task
fasttime
reviewed
Jun 6, 2025
There was a problem hiding this comment.
Is it intended that an empty array no longer matches any files? For example, this test will stop passing after this PR is merged:
configs = new ConfigArray(
[
{
files: [[]],
},
],
{
basePath,
},
);
configs.normalizeSync();
assert.strictEqual(
configs.getConfigStatus("foo/a.js"),
"matched",
);There was a problem hiding this comment.
It still matches all files, but is no longer considered an explicit match (non-universal pattern), which I think was a part of this bug. I added tests in 89ee195 to clarify this.
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fixes the problem described in eslint/eslint#19814.
What changes did you make? (Give an overview)
Fixed the code that checks for explicit matches in
filesto account for array elements offiles.Related Issues
eslint/eslint#19814
Is there anything you'd like reviewers to focus on?