Skip to content

Conversation

dubious90
Copy link
Contributor

Summary of actions/changes:

  • Update bazel/repositories
  • Other files already in sync
  • Update AddDrainedCallback calls to instead be AddIdleCallback, due to envoy PR#16948. AddIdleCallback serves an equivalent, if not exactly the same, purpose.

@dubious90 dubious90 requested a review from mum4k July 12, 2021 16:58
@dubious90 dubious90 added the waiting-for-review A PR waiting for a review. label Jul 12, 2021
@@ -1,7 +1,7 @@
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

ENVOY_COMMIT = "d3a90127f8c408651e8ab44e961408ca1fd972b4" # July 07, 2021
ENVOY_SHA = "4aed1171848e1cf4f5309d918b384b9d34aa1e7f577398caeb1d4f32c8004ee4"
ENVOY_COMMIT = "5ab509b54bf6916235b5f2b65800b9d756032129" # July 07, 2021
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the date in the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mum4k mum4k added waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. and removed waiting-for-review A PR waiting for a review. labels Jul 13, 2021
Signed-off-by: Nathan Perry <nbperry@google.com>
@dubious90 dubious90 added waiting-for-review A PR waiting for a review. and removed waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. labels Jul 13, 2021
@dubious90 dubious90 merged commit 952eecc into envoyproxy:main Jul 13, 2021
@dubious90 dubious90 deleted the envoy-update-20210712 branch August 23, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants