Skip to content

Conversation

dubious90
Copy link
Owner

No description provided.

dubious90 and others added 19 commits February 17, 2021 10:32
Signed-off-by: Nathan Perry <nbperry@google.com>
At some point clang-tidy runs broke in CI, and this couldn't be reproduced
locally. The after a while local runs would exit with a failure seemingly mid-
run.  This PR addresses both these things.

- Update the CircleCI SHA of the envoy build docker image.
- Sync the script we use to run Envoy's build docker image.
- Make clang-tidy runs use libstdc++ to avoid standard library
  headers from producing errors.
- Sync run_clang_tidy.sh
- Update MAINTAINERS.md to mention we should keep more things in sync.

Fixes #546 

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
* Fix python dependency version for benchmark image

Signed-off-by: abaptiste <abaptiste@users.noreply.github.com>
Recommend not to check for strict equality on error messages. This is aligned with [Google Cloud APIs error model](https://cloud.google.com/apis/design/errors#error_messages).

We are considering adding extra debug information to the underlying JSON parser library. The extra debug information breaks this test if it checks for strict equality.

Signed-off-by: Teju Nareddy <nareddyt@google.com>
- Sync `.bazelrc` from Envoy's repository.
- Sync `ci/run_envoy_docker.sh` from Envoy's repository.
- Update docker image version in `.circleci/config.yml`.
- The constructor of `ClusterManagerFactory` now requires an instance of `Envoy::Server::Options`. Satisfy it with `Envoy::OptionsImpl::OptionsImpl` (envoyproxy/envoy@42af11e).
- An instance of `Envoy::Event::Dispatcher` now needs to be explicitly shut down on the main thread. (envoyproxy/envoy@114d5ae).
- adjusting coverage threshold from `94.3` to `94.2`.
- fixing a `clang_tidy` issue in `output_transform_main_test.cc`.

Signed-off-by: Jakub Sobon <mumak@google.com>
Following instructions from https://github.com/envoyproxy/nighthawk/blob/main/MAINTAINERS.md#updates-to-the-envoy-dependency 

- Updated Envoy Commit and Envoy_sha in repositories.bzl.
- bazelrc, bazelversion, docker.sh remain unchanged.

Signed-off-by: William Juan <66322422+wjuan-AFK@users.noreply.github.com>
This PR has Sink, MockSink, FileSinkImpl & tests.

Sink will serve as a backing store for ExecutionResponse proto representations.

Context:
- Later on a new service will expose storage and lookup methods.
- This in turn can be used in a horizontally scaled system as a means to
realize a central point to transport results to and from.

Part of the horizontal scaling effort.
Split out from https://github.com/oschaaf/nighthawk/tree/horizontal-scaling

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
This captures something I used and for which I had to dig a bit in
the codebase to get it set up. Stashing it here may help others and
lower the bar for consumption.

I anticipate there may be more examples like this that we could
add over time. So ideally this PR will be assessed both on structure
of the initiative (/examples) and contents (MULTIPLE_ENDPOINTS.md)

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Thanks to @mklein for helping out with the dockerhub namespaces.

Fixes #611

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
- Sync `.bazelrc`
- Update Docker image version in `.circleci/config.yml`
- New way to declare Bazel pip imports in `WORKSPACE` (the `requirement("...")` side in `test/integration/BUILD` is unchanged)
- `ci/run_envoy_docker.sh` was unchanged
- Code changes
  - **Relax some byte count checks in integration tests**
    - The counters started to come out lower after updating Envoy,  e.g. 1450 decreased to 900. This was because the underlying Envoy infrastructure in the Nighthawk client stopped sending `content-length: 0` in the requests.
    - Updating the test to only check if the count is >=500, rather than checking for a specific value
      - This should still catch failure modes where Nighthawk fails after 1 request or less
      - `test_http_h2` already has such relaxed checks
  - Pass through new `TimeSource` arg in `allocateConnPool()`
  - `factoryForGrpcService()` changed the `skip_cluster_check` boolean to an enum `Envoy::Grpc::AsyncClientFactoryClusterChecks::Skip`
  - Empty `dumpState()` override added to `StreamDecoder`
  - UUID generator for tracing was moved
  - Ignore warning "Unable to use runtime singleton for feature envoy.reloadable_features.header_map_correctly_coalesce_cookies"

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Add the proto definition for the sink service plus a client implementation and test.

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
This restructures the filesytem to move everything related to `Sink` into `sink/` folders,
as too much ended up in `common/`. 

Also adds a `#pragma once` into a header that didn't have it.

That aside, this change intends to be be a no-op in terms of functional changes.

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
- `.bazelrc` was unchanged
- `.circleci/config.yml` was unchanged
- `.bazelversion` was unchanged
- `ci/run_envoy_docker.sh` was unchanged


- Code changes
  - Replace `factoryForGrpcService(..., Envoy::Grpc::AsyncClientFactoryClusterChecks::Skip)` with `factoryForGrpcService(..., /*skip_cluster_check=*/true)` due to PR #15449 in Envoy
  - Delete test `test_nighthawk_client_v2_api_explicitly_set` and `test_nighthawk_test_server_envoy_deprecated_v2_api` in `test/integration/test_integration_basics.py` since they are broken by Envoy PR #15481
  - Delete test fixture `http_test_server_fixture_envoy_deprecated_v2_api` in `test/integration/integration_test_fixtures.py`
- Update MAINTAINERS.md

Signed-off-by: qqustc@gmail.com <qqin@google.com>
The following gets emitted in the output of the build process:

DEPRECATED: the pip_repositories rule has been replaced with pip_install,
please see rules_python 0.1 release notes

This change stops that. It seems we no longer need it:
bazel-contrib/rules_python@8537cea

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: qqustc@gmail.com <qqin@google.com>
* Fix namespace dereferencing according to the style guide

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
* horizontal-scaling: message distributor

- Adds the wire skeleton of the api for a service which distributes
  messages to other load gen services & sinks.
- Adds a gRPC client implementation + unit tests

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
@dubious90 dubious90 merged commit f7d59c4 into dubious90:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants