Update Envoy to 5c553261d14730af5a2c290c4b3687ae667a65db #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notable changes: - Fixes our Http1PoolImpl to work with the updated Envoy code. - Tweaks the cluster setup: we specify at least an empty http2_protocol_options proto config. Without doing this passing --h2 to the nighthawk client would fail as caught by tests. - Moves away from using hidden_envoy_deprecated_hosts. Side effect of looking into the bevavioral change listed above. This resolves envoyproxy#377. (strictly needed for this update). Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
|
While getting this to work, I noticed that there's some duplication going on for the cluster setup code. |
mum4k
approved these changes
Jun 29, 2020
wjuan-AFK
pushed a commit
to wjuan-AFK/nighthawk
that referenced
this pull request
Jul 14, 2020
) Notable changes: - Fixes our Http1PoolImpl to work with the updated Envoy code. - Tweaks the cluster setup: we specify at least an empty http2_protocol_options proto config. Without doing this passing --h2 to the nighthawk client would fail as caught by tests. - Moves away from using hidden_envoy_deprecated_hosts. Side effect of looking into the bevavioral change listed above. This resolves envoyproxy#377. (strictly needed for this update). Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
code.
http2_protocol_options proto config. Without doing this
passing --h2 to the nighthawk client would fail as caught
by tests.
Side effect of looking into the bevavioral change listed
above. This resolves Move away from using hidden_envoy_deprecated_hosts #377. (strictly not needed for this
update).
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com