Revert "http: delaying filter stack creation until full headers have been created #3590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…been received (envoyproxy#3574)" This reverts commit 1d14b9e. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
See other comment, not related... |
|
I still think the watermark code is wrong through. I've been trying and failing to repro, but I think if the connection is aboveHighWatermark() on stream creation, we should track that immediately and not delay the check until filter chain creation, because if the state changes, I believe the stream will still get the lowWatermark callback without having gotten the high watermark callback and it'll screw up accounting. |
|
OK SGTM, let's revert if we think there is a bug here. |
mattklein123
approved these changes
Jun 11, 2018
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Jun 12, 2018
…rs have been received (envoyproxy#3574)" (envoyproxy#3590)" This reverts commit 28cea91. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1d14b9e.
Will fix the watermark issue and ask for smoke test :-)