http: delaying filter stack creation until full headers have been received #3599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs have been received (envoyproxy#3574)" (envoyproxy#3590)" This reverts commit 28cea91. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
previously approved these changes
Jun 12, 2018
|
Oops looks like master merge needed. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
(intentionally waiting until after we cut the release) |
docs/root/intro/version_history.rst
Outdated
| @@ -68,6 +68,7 @@ Version history | |||
| to elide *x-forwarded-for* header modifications. | |||
| * http: fixing a bug in inline headers where addCopy and addViaMove didn't add header values when | |||
| encountering inline headers with multiple instances. | |||
| http: response filters not applied to early error paths such as http_parser generated 400s. | |||
There was a problem hiding this comment.
Move into new release section?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
I think this is ready to go, pending approval for master merge. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precursor to creating a custom filter stack for websocket vs HTTP.
Risk Level: High
Testing: new unit tests to verify correct watermark behavior
Docs Changes: n/a
Release Notes: yes.