Revert "logger: macros evaluate logging level before invoking logger … #2730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvoyproxy#2676)" This reverts commit 8078092. Signed-off-by: Lita Cho <lcho@lyft.com>
ccaraman
approved these changes
Mar 5, 2018
|
fyi @cpakulski |
|
@ccaraman OK - thanks for info. I will try to fix it. |
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* deprecate empty proto as config Signed-off-by: Kuat Yessenov <kuat@google.com> * add protos Signed-off-by: Kuat Yessenov <kuat@google.com> * fix make lint Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#2676)"
This reverts commit 8078092.
Signed-off-by: Lita Cho lcho@lyft.com
revert: logger: macros evaluate logging level before invoking logger (#2676)
Description: Revert #2676
Risk Level: Low
Testing: N/A