Skip to content

Conversation

lizan
Copy link
Member

@lizan lizan commented Oct 29, 2019

Description:
Adds serialization method to filter state and use from logger if specified.

Risk Level: Low
Testing: CI
Docs Changes: Added
Release Notes: Will add
Fixes #8790

Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #8803 was opened by lizan.

see: more, trace.

lizan added 4 commits October 30, 2019 09:59
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested review from htuch and kyessenov October 30, 2019 18:29
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan marked this pull request as ready for review October 31, 2019 07:21
lizan added 2 commits October 31, 2019 17:48
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
Copy link
Member Author

lizan commented Oct 31, 2019

@envoyproxy/api-shepherds ping

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally approve of this approach, just some clarification request..

/wait

lizan added 2 commits November 1, 2019 10:01
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
Copy link
Member Author

lizan commented Nov 1, 2019

@htuch gentle ping, I'm blocked on this one to make WasmState serializable.

lizan added 2 commits November 4, 2019 21:01
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
htuch previously approved these changes Nov 4, 2019
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@repokitteh-read-only repokitteh-read-only bot removed the api label Nov 4, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
Copy link
Member Author

lizan commented Nov 5, 2019

/azp run envoy-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

htuch
htuch previously approved these changes Nov 5, 2019
@repokitteh-read-only repokitteh-read-only bot removed the api label Nov 5, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
Copy link
Member Author

lizan commented Nov 5, 2019

@htuch can you approve again? resolved conflicts on version_history.rst because we're in new version.

@lizan
Copy link
Member Author

lizan commented Nov 5, 2019

/azp run envoy-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lizan
Copy link
Member Author

lizan commented Nov 5, 2019

/azp run envoy-macos

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@repokitteh-read-only repokitteh-read-only bot removed the api label Nov 5, 2019
@lizan lizan merged commit cf74f81 into envoyproxy:master Nov 5, 2019
@lizan lizan deleted the filterstate_log branch November 5, 2019 22:14
lizan added a commit to envoyproxy/envoy-wasm that referenced this pull request Nov 11, 2019
Cherry-pick envoyproxy/envoy#8803 and add type to WasmState and make it serializable.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan added a commit to lizan/envoy that referenced this pull request Nov 11, 2019
Cherry-pick envoyproxy#8803 and add type to WasmState and make it serializable.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
howardjohn pushed a commit to istio/envoy that referenced this pull request Nov 12, 2019
Cherry-pick envoyproxy#8803 and add type to WasmState and make it serializable.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging support for filter state
4 participants