-
Notifications
You must be signed in to change notification settings - Fork 5.1k
access log: support filter state objects #8803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@envoyproxy/api-shepherds ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally approve of this approach, just some clarification request..
/wait
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@htuch gentle ping, I'm blocked on this one to make WasmState serializable. |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
/azp run envoy-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@htuch can you approve again? resolved conflicts on version_history.rst because we're in new version. |
/azp run envoy-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run envoy-macos |
Azure Pipelines successfully started running 1 pipeline(s). |
Cherry-pick envoyproxy/envoy#8803 and add type to WasmState and make it serializable. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Cherry-pick envoyproxy#8803 and add type to WasmState and make it serializable. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Cherry-pick envoyproxy#8803 and add type to WasmState and make it serializable. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Description:
Adds serialization method to filter state and use from logger if specified.
Risk Level: Low
Testing: CI
Docs Changes: Added
Release Notes: Will add
Fixes #8790
Signed-off-by: Lizan Zhou lizan@tetrate.io