event: reintroduce dispatcher stats #6659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Rosen <mergeconflict@google.com>
|
/review @htuch @mattklein123 |
mergeconflict
commented
Apr 19, 2019
| WorkerFactory& worker_factory) | ||
| : server_(server), factory_(listener_factory), stats_(generateStats(server.stats())), | ||
| WorkerFactory& worker_factory, | ||
| bool enable_dispatcher_stats) |
There was a problem hiding this comment.
Note: I put this here, rather than as a param in startWorkers() or a new initializeStats() method, to avoid touching the ListenerManager interface. I could do this differently if anybody feels I should...
| @@ -90,6 +96,14 @@ class DispatcherImplTest : public testing::Test { | |||
| TimerPtr keepalive_timer_; | |||
| }; | |||
|
|
|||
| // TODO(mergeconflict): We also need integration testing to validate that the expected histograms | |||
| // are written when `enable_dispatcher_stats` is true. See issue #6582. | |||
There was a problem hiding this comment.
I'm planning to implement integration tests in a following PR, once I've dealt with #6582, if that's still ok.
| running---but if this number elevates substantially above its normal observed baseline, it likely | ||
| indicates kernel scheduler delays. | ||
|
|
||
| These statistics can be enabled by setting :ref:`enable_dispatcher_stats <envoy_api_field_config.bootstrap.v2.Bootstrap.enable_dispatcher_stats>` |
htuch
reviewed
Apr 19, 2019
| // Enable :ref:`stats for event dispatcher <operations_performance>`, defaults to false. | ||
| // Note that this records a value for each iteration of the event loop on every thread. This | ||
| // should normally be minimal overhead, but when using | ||
| // :ref:`statsd <envoy_api_msg_config.metrics.v2.StatsdSink>`, it will send each observed value |
There was a problem hiding this comment.
Is it just statsd or also other stats sinks?
There was a problem hiding this comment.
Yes, just statsd. The Monarch sink appears to just dump histograms on the floor, and the Hystrix and Metrics sinks both do the right thing with parent histograms.
|
/retest |
|
🔨 rebuilding |
htuch
previously approved these changes
Apr 22, 2019
Signed-off-by: Dan Rosen <mergeconflict@google.com>
|
@mergeconflict needs master merge for version history. |
htuch
approved these changes
Apr 23, 2019
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Apr 24, 2019
* master: docs: add extension policy (envoyproxy#6678) ext_authz: added ability to detect partial request body data (envoyproxy#6583) version_history.rst: jwt_authn change missed 1.10.0 (envoyproxy#6684) docs: fix link in pull request template (envoyproxy#6679) Explicitly convert absl::string_view to std::string. (envoyproxy#6687) docs: improving watermark docs/comments (envoyproxy#6683) http filter: add CSRF filter (envoyproxy#6470) event: reintroduce dispatcher stats (envoyproxy#6659) security: postmortem for CVE-2019-990[01] (envoyproxy#6597) Improve build rules for (test only) library quic_port_utils. (envoyproxy#6672) spell check: skip unsupported extensions when called with a file (envoyproxy#6648) Changed TestHooks to ListenerHooks (envoyproxy#6642) proto: move extension-specific linking validation into extensions (envoyproxy#6657) stats: add/test heterogenous set of StatNameStorage objects. (envoyproxy#6504) docs: move xds protocol to rst (envoyproxy#6670) fix version history order (envoyproxy#6671) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Reintroduce dispatcher stats previously reverted in #6649. Dispatcher stats are now gated on a new bootstrap config parameter,
enable_dispatcher_stats, and disabled by default.Risk Level: Low
Testing: Manually verified that config is respected (see #6582, this still requires integration tests).
Docs Changes: Included a note about how statsd doesn't play well with these high-volume histograms.
Signed-off-by: Dan Rosen mergeconflict@google.com