build: bump rules_foreign_cc to e3f4b5e0 and switch to lld for .bazel… #6610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rc sanitizers. This allows for all --copt/--cxxopt/--linkopt to be plumbed to external dependencies. Risk level: Low Testing: CI Signed-off-by: Harvey Tuch <htuch@google.com>
|
@htuch ASAN/TSAN test failed, so the flags are propagated down to dependencies? |
Signed-off-by: Harvey Tuch <htuch@google.com>
|
@mergeconflict is looking at the TSAN failure related to |
Closed
Signed-off-by: Harvey Tuch <htuch@google.com>
|
|
htuch
pushed a commit
that referenced
this pull request
Apr 18, 2019
@htuch discovered a race condition in my libevent watcher implementation in the process of enabling TSAN for dependencies (#6610). Update libevent to pull in the fix (libevent/libevent#793). Risk Level: low Testing: bazel test //test/server:worker_impl_test -c dbg --config=clang-tsan --runs_per_test=1000 (with @htuch's patch applied). Signed-off-by: Dan Rosen <mergeconflict@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
reviewed
Apr 24, 2019
Signed-off-by: Harvey Tuch <htuch@google.com>
|
@lizan this is ready for final review, all tests should now pass. |
lizan
reviewed
Apr 24, 2019
| + # Blacklist LuaJIT from ASAN for now. | ||
| + # TODO(htuch): Remove this when https://github.com/envoyproxy/envoy/issues/6084 is resolved. | ||
| + if "ENVOY_CONFIG_ASAN" in os.environ: | ||
| + os.environ["TARGET_CFLAGS"] += " -fsanitize-blacklist=%s/com_github_luajit_luajit/clang-asan-blacklist.txt" % os.environ["PWD"] |
There was a problem hiding this comment.
if we do fun:* blacklist, shall we just remove -fsanitize=address from TARGET_CFLAGS?
There was a problem hiding this comment.
It's a useful hook to leave around to experiment with making this more precise, so I'd vote to keep it as is.
lizan
approved these changes
Apr 24, 2019
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 26, 2019
Since envoyproxy#6610 the fuzzer build has been broken. This is due to the interaction of rules_foreign_cc external dependencies and the additional UBSAN blacklist maintained by the oss-fuzz driver to workaround the fact we don't have protocolbuffers/protobuf#5901 yet. Thir PR moves protocolbuffers/protobuf#5901 into Envoy proper and hence we don't need an UBSAN blacklist in the oss-fuzz driver anymore. Risk level: Low Tesitng: oss-fuzz Docker build. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
to htuch/oss-fuzz
that referenced
this pull request
Apr 26, 2019
This is no longer needed as we handle this Envoy-side. This should fix the build that has been broken since envoyproxy/envoy#6610. Signed-off-by: Harvey Tuch <htuch@google.com>
inferno-chromium
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Apr 26, 2019
This is no longer needed as we handle this Envoy-side. This should fix the build that has been broken since envoyproxy/envoy#6610. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
that referenced
this pull request
Apr 26, 2019
Since #6610 the fuzzer build has been broken. This is due to the interaction of rules_foreign_cc external dependencies and the additional UBSAN blacklist maintained by the oss-fuzz driver to workaround the fact we don't have protocolbuffers/protobuf#5901 yet. This PR moves protocolbuffers/protobuf#5901 into Envoy proper and hence we don't need an UBSAN blacklist in the oss-fuzz driver anymore. Risk level: Low Tesitng: oss-fuzz Docker build. Signed-off-by: Harvey Tuch <htuch@google.com>
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
Since envoyproxy#6610 the fuzzer build has been broken. This is due to the interaction of rules_foreign_cc external dependencies and the additional UBSAN blacklist maintained by the oss-fuzz driver to workaround the fact we don't have protocolbuffers/protobuf#5901 yet. This PR moves protocolbuffers/protobuf#5901 into Envoy proper and hence we don't need an UBSAN blacklist in the oss-fuzz driver anymore. Risk level: Low Tesitng: oss-fuzz Docker build. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rc sanitizers.
This allows for all --copt/--cxxopt/--linkopt to be plumbed to external
dependencies.
Risk level: Low
Testing: CI
Signed-off-by: Harvey Tuch htuch@google.com