build: fix external cmake path #5787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan
commented
Jan 31, 2019
| @@ -43,6 +43,7 @@ cmake_external( | |||
| "ENABLE_STATIC_LIB": "on", | |||
| "ENABLE_LIB_ONLY": "on", | |||
| "CMAKE_BUILD_TYPE": "RelWithDebInfo", | |||
| "CMAKE_INSTALL_LIBDIR": "lib", | |||
There was a problem hiding this comment.
This is due to in some platform it will pick lib64 and bazel won't pick built .a file. It was defined in previous nghttp2.sh
|
@htuch #5218 breaks consuming repo, e.g. https://circleci.com/gh/envoyproxy/envoy-filter-example/2994 |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Risk Level: Low
Testing: CI
Docs Changes:
Release Notes: