Skip to content

Conversation

liamawhite
Copy link
Contributor

@liamawhite liamawhite commented Jan 31, 2019

Description: Add a link to ejection event logging.
Risk Level: low
Testing: none
Docs Changes: Only doc changes!
Release Notes: none

When reading docs it wasn't immediately clear where to configure the Ejection event logging. This change explicitly links to it.

When reading docs it wasn't immediately clear where to configure the Ejection event logging. This change explicitly links to it.

Signed-off-by: Liam White <liam@tetrate.io>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattklein123 mattklein123 merged commit b4ef202 into envoyproxy:master Jan 31, 2019
fredlas pushed a commit to fredlas/envoy that referenced this pull request Mar 5, 2019
When reading docs it wasn't immediately clear where to configure the Ejection event logging. This change explicitly links to it.

Signed-off-by: Liam White <liam@tetrate.io>
Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants