build: fix cc_wrapper.py treatment of -lc++. #5743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was the intended code, I noticed a failure in compile_time_options for envoyproxy#5218. Risk Level: Low Testing: bazel build --config=libc++ //source/exe:envoy-static Signed-off-by: Harvey Tuch <htuch@google.com>
|
@PiotrSikora while working on #5218, I hit this issue where I'd like to add a regression test for this, but I don't seem to be able to rebuild with Can you take a look at this and let me know what your thoughts are? |
PiotrSikora
approved these changes
Jan 29, 2019
ggreenway
approved these changes
Jan 29, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 31, 2019
I think this was the intended code, I noticed a failure in compile_time_options for envoyproxy#5218. Risk Level: Low Testing: bazel build --config=libc++ //source/exe:envoy-static Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: htuch <htuch@users.noreply.github.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
I think this was the intended code, I noticed a failure in compile_time_options for envoyproxy#5218. Risk Level: Low Testing: bazel build --config=libc++ //source/exe:envoy-static Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was the intended code, I noticed a failure in
compile_time_options for
#5218.
Risk Level: Low
Testing: bazel build --config=libc++ //source/exe:envoy-static
Signed-off-by: Harvey Tuch htuch@google.com