jwt_authn: cleanup, separate verifier from the matcher #5689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
|
@potatop Could you help to review this change? |
lizan
approved these changes
Jan 23, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 24, 2019
Signed-off-by: Wayne Zhang <qiwzhang@google.com> Signed-off-by: Dan Zhang <danzh@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 31, 2019
Signed-off-by: Wayne Zhang <qiwzhang@google.com> Signed-off-by: Wayne Zhang <qiwzhang@gmail.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Wayne Zhang <qiwzhang@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Zhang qiwzhang@google.com
Description:
This is just code cleanup. Now Verifier object is stored in Matcher and accessed by calling its verifier() function. It will be cleaner to store matcher and verifier separately as a pair in the filer_config.
Also changed to use unique_ptr for Matcher too.
s/MatcherConstSharedPtr/MatcherConstPtr
Risk Level: None
Testing: All unit-tests