Skip to content

Conversation

gsagula
Copy link
Member

@gsagula gsagula commented Jan 21, 2019

Description:
This PR fixes #5138. Changes were also made to a portion of the documentation in the effort of making it more clear.

Risk Level: low
Testing: no
Docs Changes: yes
Release Notes: yes

Gabriel added 6 commits January 15, 2019 16:27
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
@mattklein123 mattklein123 self-assigned this Jan 22, 2019
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. LGTM with a few small nits.

/wait

Signed-off-by: Gabriel <gsagula@gmail.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattklein123 mattklein123 merged commit a15dbc9 into envoyproxy:master Jan 23, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Jan 24, 2019
…xy#5672)

Signed-off-by: Gabriel <gsagula@gmail.com>

Signed-off-by: Dan Zhang <danzh@google.com>
fredlas pushed a commit to fredlas/envoy that referenced this pull request Mar 5, 2019
…xy#5672)

Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate ext_auth away from alpha config
2 participants