mysql_proxy: access EnvoyException by reference. #5669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation fails because Envoy::EnvoyException values are caught by value. Change the catching to references to fix the issue. source/extensions/filters/network/mysql_proxy/mysql_utils.cc:100:27: error: catching polymorphic type 'class Envoy::EnvoyException' by value [-Werror=catch-value=] Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Jan 24, 2019
Compilation fails because Envoy::EnvoyException values are caught by value. Change the catching to references to fix the issue. source/extensions/filters/network/mysql_proxy/mysql_utils.cc:100:27: error: catching polymorphic type 'class Envoy::EnvoyException' by value [-Werror=catch-value=] Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com> Signed-off-by: Dan Zhang <danzh@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Compilation fails because Envoy::EnvoyException values are caught by value. Change the catching to references to fix the issue. source/extensions/filters/network/mysql_proxy/mysql_utils.cc:100:27: error: catching polymorphic type 'class Envoy::EnvoyException' by value [-Werror=catch-value=] Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Compilation failed because Envoy::EnvoyException values were caught by value. Change the catching to references to fix the issue.
The error message was this:
Risk Level: Low
Testing:
Ran unit tests. One test (
MySQLCommandTest.MySQLTest39) failed. But since that test was expecting a success case (MYSQL_SUCCESS), the test failure probably isn't related. Without the patch, I couldn't run the test due to the compilation issue.Docs Changes: N/A
Release Notes: N/A