test: fix ssl_integration_test flake. #5650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SSL client disconnects and continues execution in the main test thread, while the server side code responsible for the stats had not updated the stat yet. Fixes envoyproxy#5420. Risk level: Low Testing: bazel test test/integration:ssl_integration_test test/integration/ssl_integration_test.cc --runs_per_test=1000 Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Jan 18, 2019
|
Thanks @htuch! |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
The SSL client disconnects and continues execution in the main test thread, while the server side code responsible for the stats had not updated the stat yet. Fixes envoyproxy#5420. Risk level: Low Testing: bazel test test/integration:ssl_integration_test test/integration/ssl_integration_test.cc --runs_per_test=1000 Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSL client disconnects and continues execution in the main test
thread, while the server side code responsible for the stats had not
updated the stat yet.
Fixes #5420.
Risk level: Low
Testing: bazel test test/integration:ssl_integration_test
test/integration/ssl_integration_test.cc --runs_per_test=1000
Signed-off-by: Harvey Tuch htuch@google.com