misc changes in support of HTTP tap #5553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are various changes split out from #5515. They include: 1) Allow the admin server to be accessed over HTTP/2 with prior knowledge. This is required to get the tap integration tests to pass on OSX. 2) Change admin to buffer the complete request so that admin handlers can support POST bodies. 3) Small integration test fix in waitForBodyData() to avoid a race condition in which the body data arrives before the call. 4) Small comment and clang-tidy fixes. Signed-off-by: Matt Klein <mklein@lyft.com>
|
@lizan @alyssawilk PTAL |
|
/retest |
|
🔨 rebuilding |
alyssawilk
reviewed
Jan 9, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
|
@alyssawilk updated |
alyssawilk
approved these changes
Jan 9, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
These are various changes split out from envoyproxy#5515. They include: 1) Allow the admin server to be accessed over HTTP/2 with prior knowledge. This is required to get the tap integration tests to pass on OSX. 2) Change admin to buffer the complete request so that admin handlers can support POST bodies. 3) Small integration test fix in waitForBodyData() to avoid a race condition in which the body data arrives before the call. 4) Small comment and clang-tidy fixes. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are various changes split out from
#5515. They include:
knowledge. This is required to get the tap integration tests to
pass on OSX.
can support POST bodies.
condition in which the body data arrives before the call.
Risk Level: Low
Testing: Existing/new UTs and integration tests.
Docs Changes: N/A
Release Notes: Added