tcp_proxy: convert TCP proxy to use TCP connection pool #4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts TcpProxy::Filter and WebSocket::WsHandlerImpl to use Tcp::ConnectionPool to obtain connections. Much of the stats handling and connection timeouts are handled by the connection pool. Stats were manually verified by comparing stats produced by the tcp_proxy_integration_test with and without the connection pool change. This reapplies an earlier changed reverted due to envoyproxy#4066. That bug is fixed by performing the connection pools state management before forwarding callbacks. *Risk Level*: medium *Testing*: unit/integration testing *Docs Changes*: n/a *Release Notes*: n/a *Fixes*: envoyproxy#4066 Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
…arding callbacks and tracking whether the connection has been invalidated or not (allowing the callback to use the connection to e.g., obtain a dispatcher). Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
|
FYI, the first commit is just a revert of the revert commit (6a1868d). The second commit fixes the bug. |
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
mattklein123
approved these changes
Aug 7, 2018
|
@mattklein123 or @danielhochman, since I blew up one of your deploys already, do you want to experiment with this change or shall I go ahead and merge it? |
|
Will defer to @danielhochman @ccaraman @junr03 if they want to smoke test. Might be worth it. |
danielhochman
approved these changes
Aug 9, 2018
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Aug 30, 2018
…oyproxy#4067)" This reverts commit 04616d6. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Aug 30, 2018
…yproxy#4067)" This reverts commit 04616d6. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
added a commit
to istio/envoy
that referenced
this pull request
Aug 30, 2018
…yproxy#4067)" This reverts commit 04616d6. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts TcpProxy::Filter and WebSocket::WsHandlerImpl to use
Tcp::ConnectionPool to obtain connections. Much of the stats
handling and connection timeouts are handled by the connection
pool.
Stats were manually verified by comparing stats produced by
the tcp_proxy_integration_test with and without the connection
pool change.
This reapplies an earlier changed reverted due to #4065. That
bug is fixed by performing the connection pools state management
before forwarding callbacks.
Risk Level: medium
Testing: unit/integration testing
Docs Changes: n/a
Release Notes: n/a
Fixes: #4065
Signed-off-by: Stephan Zuercher stephan@turbinelabs.io