Add client parameter to TestClient
#2810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested changes
Dec 26, 2024
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
client parameter to TestClient
Kludex
reviewed
Dec 26, 2024
Kludex
approved these changes
Dec 26, 2024
|
Thanks! :) |
WilliamDEdwards
added a commit
to WilliamDEdwards/starlette
that referenced
this pull request
Feb 15, 2025
With encode#2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address). The default value for `TestClient` is `testclient`, but an IP address in most circumstances. The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.
3 tasks
Kludex
pushed a commit
that referenced
this pull request
Feb 16, 2025
…..)` example (#2870) With #2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address). The default value for `TestClient` is `testclient`, but an IP address in most circumstances. The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.
github-actions bot
pushed a commit
to Kludex/jik
that referenced
this pull request
Feb 17, 2025
…..)` example (#2870) With encode/starlette#2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address). The default value for `TestClient` is `testclient`, but an IP address in most circumstances. The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2295
Added client and port parameter to TestClient