Rename max_file_size to spool_max_size
#2780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
approved these changes
Dec 3, 2024
3 tasks
0423cfe to
87b4dec
Compare
|
I tried to add a deprecation warning, but the effort didn't seem to pay off. |
4 tasks
falkoschindler
pushed a commit
to zauberzeug/nicegui
that referenced
this pull request
Apr 21, 2025
…se new parameter name (#4640) Following the method described in the docs [here](https://nicegui.io/documentation/upload#uploading_large_files) no longer works. I did some digging and it's because of changes to starlette: * `MultiPartParser`: Rename `max_file_size` to `spool_max_size` [#2780](encode/starlette#2780). Co-authored-by: Daniel Yudelevich <dyudelevich@madobjective.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@defnull is this what you mentioned some months ago?