Fix multi-line TextShape rotation
#7404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7404-fix-text-rotation |
lucasmerlin
reviewed
Aug 5, 2025
Co-authored-by: Lucas Meurer <hi@lucasmerlin.me>
emilk
approved these changes
Aug 5, 2025
emilk
added a commit
that referenced
this pull request
Aug 15, 2025
* Closes <#7397> * [X] I have followed the instructions in the PR template I do admit I got a peak NixOS `RequestDeviceError` and deemed it entirely not worth it to think about that. #5411 broke rotation of multi-line `TextShape`s because `PlacedRow::pos` was no longer being rotated, so let's rotate it. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com> Co-authored-by: Lucas Meurer <hi@lucasmerlin.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextShaperotation newly broken in 0.32 #7397I do admit I got a peak NixOS
RequestDeviceErrorand deemed it entirely not worth it to think about that.#5411 broke rotation of multi-line
TextShapes becausePlacedRow::poswas no longer being rotated, so let's rotate it.