Ensure TextEdit cursor is never out of bounds #7077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rendering a TextArea we don't know if the saved cursor applies to the current galley since it's possible the app changed the TextBuffer (e.g. when submitting a chat input) So we now detect if the galley changed from the last known one and clamp the cursor to ensure it's not out of bounds. This fixes an issue where backspace can suddenly stop working Repro: - Render TextArea with long-ish text (say 20 chars) - Without losing focus, clear the text - Write something short (say 5 chars) - Result: backspace doesn't work because the cursor position is wrong
|
Preview available at https://egui-pr-preview.github.io/pr/7077-fix-out-of-bounds-cursor |
|
The removed It's been a while since I made those changes so I could be totally off-base. |
1 task
juancampa
added a commit
to membrane-io/egui
that referenced
this pull request
May 26, 2025
) When rendering a TextArea we don't know if the saved cursor applies to the current galley since it's possible the app changed the TextBuffer (e.g. when submitting a chat input) So we now detect if the galley changed from the last known one and clamp the cursor to ensure it's not out of bounds. This fixes an issue where backspace can suddenly stop working Repro: - Render TextArea with long-ish text (say 20 chars) - Without losing focus, clear the text - Write something short (say 5 chars) - Result: backspace doesn't work because the cursor position is wrong
juancampa
added a commit
to membrane-io/egui
that referenced
this pull request
May 26, 2025
) When rendering a TextArea we don't know if the saved cursor applies to the current galley since it's possible the app changed the TextBuffer (e.g. when submitting a chat input) So we now detect if the galley changed from the last known one and clamp the cursor to ensure it's not out of bounds. This fixes an issue where backspace can suddenly stop working Repro: - Render TextArea with long-ish text (say 20 chars) - Without losing focus, clear the text - Write something short (say 5 chars) - Result: backspace doesn't work because the cursor position is wrong
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2025
Closes #7077. This fixes the problem shown in #7077 where clearing a `TextEdit` wouldn't reset its cursor position. I've fixed that by adding back the `TextCursorState::range` method, which clamps the selection range to that of the passed `Galley`, and calling it in the same places where it was called before #5785. (/cc @juancampa) * [x] I have followed the instructions in the PR template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering a TextArea we don't know if the saved cursor applies to the current galley since it's possible the app changed the TextBuffer (e.g. when submitting a chat input)
So we now detect if the galley changed from the last known one and clamp the cursor to ensure it's not out of bounds.
This fixes an issue where backspace and arrow keys can suddenly stop working. In this video I changed the
TextAreato not lose focus when enter is pressed (using.return_key). And instead, the app clears theString. Which is what we do in our chat and REPL UIs.Repro:
I think this issue started happening when this function was removed in #5785
(cc @valadaptive in case you happen to know of a better fix that doesn't require keeping the Galley in the TextEdit state)