Skip to content

model: Add GreenNode Vietnamese Embedding models #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 18, 2025

Conversation

BaoLocPham
Copy link
Contributor

@BaoLocPham BaoLocPham commented Aug 7, 2025

Hi, I'm about to add some Vietnamese text embedding model.
These models was test on #2964

  • I have filled out the ModelMeta object to the extent possible
    I have ensured that my model can be loaded using
  • mteb.get_model(model_name, revision) and
  • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.
  • The model is public, i.e. is available either as an API or the wieght are publicly avaiable to download

@KennethEnevoldsen
Copy link
Contributor

waiting on: #2964

@BaoLocPham BaoLocPham marked this pull request as ready for review August 9, 2025 15:52
@KennethEnevoldsen KennethEnevoldsen changed the title model [ADD] GreenNode Vietnamese Embedding models model: Add GreenNode Vietnamese Embedding models Aug 17, 2025
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note on the where the models are places - otherwise the metadata looks great

@@ -1788,3 +1788,49 @@
training_datasets=None,
superseded_by=None,
)

sup_simcse_vietnamese_phobert_base_ = ModelMeta(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sup_simcse_vietnamese_phobert_base_ = ModelMeta(
sup_simcse_vietnamese_phobert_base = ModelMeta(

@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) August 17, 2025 17:02
auto-merge was automatically disabled August 18, 2025 03:24

Head branch was pushed to by a user without write access

@Samoed Samoed enabled auto-merge (squash) August 18, 2025 07:56
@Samoed Samoed merged commit 72f7b05 into embeddings-benchmark:main Aug 18, 2025
10 checks passed
q275343119 pushed a commit to q275343119/mteb that referenced this pull request Aug 18, 2025
…k#2994)

* [ADD] 50 vietnamese dataset from vn-mteb

* [UPDATE] task metadata

* [UPDATE] import dependencies

* [UPDATE] task metadata, bibtext citation

* [UPDATE-TEST] test_model_meta

* [UPDATE] sample_creation to machine-translated and LM verified

* [ADD] sample creation machine-translated and LM verified

* [ADD] Vietnamese Embedding models

* [REMOVE] default fields metadata in Classfication tasks

* [UPDATE] model to vi-vn language specific file

* [FIX] lint

* [FIX] model loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants