Skip to content

rename Evaluators to avoid ambiguity #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

rename Evaluators to avoid ambiguity #2962

wants to merge 12 commits into from

Conversation

KennethEnevoldsen
Copy link
Contributor

partly adresses #1124 (the Image folder still need a renames)

@KennethEnevoldsen KennethEnevoldsen requested a review from Samoed July 31, 2025 09:24
Samoed
Samoed reviewed Jul 31, 2025
View reviewed changes
mteb/evaluation/evaluators/__init__.py

__all__ = [
"Evaluator",
"AnySTSEvaluator",
"SummarizationEvaluator",
"sts_evaluator",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you shouldn't change values in __all__

Base automatically changed from clean-v2 to v2.0.0 August 3, 2025 14:22
@KennethEnevoldsen
Copy link
Contributor Author

I agree - due to the merge conflict then I will just redo the PR

KennethEnevoldsen added a commit that referenced this pull request Aug 3, 2025
@KennethEnevoldsen
fix: rename evaluators rename to snakecase
6cc0377 
same as #2962 (but avoiding merge conflicts)
fixes #1124
@KennethEnevoldsen KennethEnevoldsen mentioned this pull request Aug 3, 2025
Closed
KennethEnevoldsen added a commit that referenced this pull request Aug 3, 2025
@KennethEnevoldsen
fix: rename evaluators rename to snakecase
2fb41ee 
same as #2962 (but avoiding merge conflicts)
fixes #1124
@KennethEnevoldsen KennethEnevoldsen mentioned this pull request Aug 3, 2025
Merged
KennethEnevoldsen added a commit that referenced this pull request Aug 3, 2025
@KennethEnevoldsen
fix: rename evaluators rename to snakecase (#2979)
5100117 
* fix: rename evaluators rename to snakecase

same as #2962 (but avoiding merge conflicts)
fixes #1124

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samoed Samoed Samoed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KennethEnevoldsen @Samoed