[v2] Merge MIEB into v2
#1973
Merged
[v2] Merge MIEB into v2
#1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix training data * Fix data * Fix data --------- Co-authored-by: Kenneth Enevoldsen <kennethcenevoldsen@gmail.com>
Update SCIDOCSNLRetrieval.py
* add model memory usage * lint * update * calculate memory usage based on file size * calculate memory usage * add memory usage for MIEB models * add last model usage * add memory_usage_mb to overview * fix rerank * update memory usage * update memory usage
# Conflicts: # mteb/model_meta.py # mteb/models/gritlm_models.py # mteb/models/overview.py # mteb/models/promptriever_models.py # mteb/tasks/Retrieval/eng/HagridRetrieval.py
# Conflicts: # tests/test_tasks/test_all_abstasks.py
# Conflicts: # mteb/benchmarks/benchmarks.py # mteb/tasks/__init__.py # mteb/tasks/aggregated_tasks/__init__.py
# Conflicts: # mteb/model_meta.py # mteb/models/bge_models.py # mteb/models/cde_models.py # mteb/models/cohere_models.py # mteb/models/colbert_models.py # mteb/models/e5_instruct.py # mteb/models/google_models.py # mteb/models/gritlm_models.py # mteb/models/jasper_models.py # mteb/models/jina_models.py # mteb/models/lens_models.py # mteb/models/llm2vec_models.py # mteb/models/misc_models.py # mteb/models/model2vec_models.py # mteb/models/no_instruct_sentence_models.py # mteb/models/nomic_models.py # mteb/models/openai_models.py # mteb/models/promptriever_models.py # mteb/models/repllama_models.py # mteb/models/ru_sentence_models.py # mteb/models/salesforce_models.py # mteb/models/uae_models.py # mteb/models/voyage_models.py
|
@isaac-chung Can you review PR? |
isaac-chung
reviewed
Feb 8, 2025
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| @pytest.mark.parametrize("task", MOCK_TASK_TEST_GRID) | |||
| def test_descriptive_stats(task): | |||
| # todo integrate MIEB | |||
There was a problem hiding this comment.
Is this meant to be done in this PR?
There was a problem hiding this comment.
No. Not all MIEB tasks have implemented calculate_descripteve_stats this test should be updated after it
gowitheflow-1998
approved these changes
Feb 8, 2025
isaac-chung
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Quality
make lintto maintain consistent style.Documentation
Testing
make test-with-coverage.make testormake test-with-coverageto ensure no existing functionality is broken.